Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1949

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SamanthaMoraes2629
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your implementation of the Car and CarWashStation classes is well-aligned with the task requirements and constraints. 🎉 While there are minor issues, such as the use of a backslash for line continuation and comments in Portuguese, these do not significantly impact the functionality of your code. For future improvements, consider translating comments to English for consistency and refactoring the line continuation for better readability. Keep up the great work! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +39 to +40
price = (car.comfort_class * (self.clean_power - car.clean_mark)) * \
(self.average_rating / self.distance_from_city_center)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of a backslash for line continuation is not recommended. According to the checklist, you should break after binary operations instead of using a backslash. Consider refactoring this line to improve readability and adhere to the style guide.

Comment on lines +23 to +28
# distance_from_city_center - quão longe a estação está do centro da
# cidade, de 1,0 a 10,0
# clean_power - clean_mark para onde este posto de lavagem de carros lava
# average_rating - classificação média da estação, de 1,0 a 5,0,
# arredondada para 1 casa decimal
# count_of_ratings - número de pessoas que avaliaram

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comments explaining the parameters are in Portuguese. If the rest of your code and documentation are in English, it would be better to translate these comments to maintain consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants