Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1935

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PlatonGoncharevskyi
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the Car and CarWashStation classes! 🎉 Your code meets the task requirements and constraints, and the methods are correctly implemented. However, there's a potential division by zero error in the calculate_washing_price method. It would be a good idea to add a check to ensure distance_from_city_center is not zero before performing the division. Keep up the good work and happy coding! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

def calculate_washing_price(self, car):
price = (
car.comfort_class * (self.clean_power - car.clean_mark) *
self.average_rating / self.distance_from_city_center

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a potential division by zero error here. If distance_from_city_center is zero, this will raise an exception. Consider adding a check to ensure distance_from_city_center is not zero before performing this division.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants