Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1931

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

YaroslavDidkiviskiy
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the Car and CarWashStation classes! 🎉 Your code meets the task requirements and constraints effectively. While there are a couple of areas to double-check, such as the logic for updating the car's clean mark and the formula for calculating the washing price, these are minor and do not impact the overall functionality. Keep up the good work, and consider reviewing these points for future improvements. Well done! 🚗✨

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +30 to +31
car.comfort_class * (self.clean_power - car.clean_mark)
* (self.average_rating / self.distance_from_city_center)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The formula for calculating the washing price might need verification. Ensure that it aligns with the task requirements. If the task specifies a different formula or additional factors, adjust accordingly.

Comment on lines +36 to +37
if self.clean_power > car.clean_mark:
car.clean_mark = self.clean_power

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic for updating the car's clean mark should be reviewed. Ensure that the task requirements specify that the clean mark should be set to the clean power after washing. If there are additional conditions or a different approach required, adjust this logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants