Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #4683

Closed
wants to merge 2 commits into from
Closed

add task solution #4683

wants to merge 2 commits into from

Conversation

ser1stydent
Copy link

@ser1stydent ser1stydent commented Mar 5, 2024

Copy link

@loralevitska loralevitska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please redeploy test report link
image

Comment on lines +34 to +35
<a class="nav__link laptops" data-qa="hover"
href="#laptops s computers">Laptops & Computers</a>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<a class="nav__link laptops" data-qa="hover"
href="#laptops s computers">Laptops & Computers</a>
<a
class="nav__link laptops"
data-qa="hover"
href="#laptops s computers"
>
Laptops & Computers
</a>

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines +15 to +20
padding: 0 50px;
display: flex;
justify-content: space-between;
left: 0;
right: 0;
align-items: center;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rewrite styles in correct orders https://9elements.com/css-rule-order/
Fix all cases

align-items: center;
}

.logo {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix all cases (remove redundant whitespaces)

Suggested change
.logo {
.logo {

@ser1stydent
Copy link
Author

Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please, fix all previous comments and fix your demo inks

if you have some problems with that then feel free to ask for some help in the chat

@ser1stydent ser1stydent requested a review from etojeDenys March 6, 2024 17:38
Copy link

@Esceype Esceype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your demo now works but the issues are still the same, fix it and don`t forget to commit them and push

@ser1stydent ser1stydent closed this by deleting the head repository Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants