Added support for tags #196

pdelaby · 2018-11-29T08:44:26Z

I love your theme, so I added the support for one of the default taxonomy in GoHugo : tags.

I also added documentation in the exampleSite, and the theme variants.

I only doubt about the CSS, if anyone have a better idea don't hesitate :-)

Display tags list when clicking on tag

gilbsgilbs · 2019-03-13T15:00:00Z

I am very interested by this feature. Can I help?

matalo33 · 2019-03-13T16:02:18Z

There's a couple of things if you would like to contribute.

Review the code
Run the branch on the example site or your own sites and test functionality

I notice @pdelaby added tags to the sample site however when this MR was opened the netlify build was not working. Could you rebase this against master to kick a fresh build? It will render an entirely new copy of the example site along with the changes.

gilbsgilbs · 2019-03-13T16:51:18Z

@matalo33 Thanks. I currently run a rebased version of @pdelaby's work on a private project and it works fine (except that I have to restart the server when I touch to taxonomies, but I think it's a limitation from hugo itself).

Here are some screenshots showing how it looks:

After clicking on a tag, it looks like this:

As far as I'm concerned, I think it looks good overall. If I had anything to say, I would say that the taxonomy page (third screenshot) is not very good looking, but I'm not sure how to improve it. At very least, punctuation is incorrect in english and should be fixed.

I don't have much to say on the implementation itself. It looks correctly written to me however I don't contribute a lot to Hugo themes.

There are obvious typos in the English docs, I'll mention the ones I find. Yet, the french version looks perfect.

gilbsgilbs · 2019-03-13T16:51:58Z

exampleSite/content/cont/tags.en.md

+tags: ["documentation", "tutorial"]
+---
+
+*Learn theme* support one default taxonomy of gohugo : the *tag* feature.


There's no space before colons in english.

gilbsgilbs · 2019-03-13T16:52:09Z

exampleSite/content/cont/tags.en.md

+
+## Configuration 
+
+Just add tags to any page : 


There's no space before colons in english.

gilbsgilbs · 2019-03-13T16:54:25Z

exampleSite/content/cont/tags.en.md

+## Behavior
+
+
+The tags are displayed at the top of the page, in the order wich they are enterted.


- wich + which

- enterted + entered

Not even sure the use of the verb enter is correct here. Maybe “in order of insertion” is slightly better?

gilbsgilbs · 2019-03-13T16:56:23Z

layouts/partials/header.html

-            <h1>{{.Title}}</h1>
+            <h1>
+              {{ if eq .Kind "taxonomy" }}
+                {{.Kind}} :


English doesn't have spaces before colons. Not sure how to handle this 🤔 .

I found no other usage of colons in the theme, except for the title <title>{{ .Title }} :: {{ .Site.Title }}</title>. Maybe we can use double quotes, or some kind of emphasis in order to get rid of the colon?

A good solution could be to use the lang attribute of the html tag, and CSS. Wrapping the colon in a span <span class="colon">:</span> could allow to use something like:

html[lang="fr"] .colon{ padding-left:0.2em; }

But even with the fr-fr language code in config.toml, I did not found a way to change the lang attribute in html (which is always en).

I'd say :: is good enough. Pretty sure I've already seen it somewhere. @matalo33 what do you think?

gilbsgilbs · 2019-03-13T16:57:11Z

layouts/partials/tags.html

@@ -0,0 +1,7 @@
+<div class="tags">
+  {{ if .Params.tags }}


Maybe this should wrap the div so that we don't even display the div when there are no tags.

gilbsgilbs · 2019-03-13T16:57:42Z

layouts/partials/tags.html

+<div class="tags">
+  {{ if .Params.tags }}
+    {{range .Params.tags}}
+      <a class="tag-link" href="{{ "/tags/" | relLangURL }}{{ . | urlize }}">{{ . }} </a>


Useless trailing space?

pdelaby · 2019-03-14T09:38:12Z

Thanks for the help @gilbsgilbs :-) Sorry for the english typos.

We are using this feature on our projects (with a forked repository for now) for 4 months now, and found no bugs yet. Some insights about it :

the tags are case insensitive,
you can search the tags, wich is really cool,
on the taxonomy page, we miss a feature which woud show the number of pages with the tage ( "my first tag (8)", "my second tag (2)", but I don't know how to implement it.

During edition (hugo server -D), I don't have to restart the hugo server to see taxonomy changes (add/remove a tag). What do you mean by "touch to taxonomies" ?

gilbsgilbs · 2019-03-14T17:30:30Z

What do you mean by "touch to taxonomies" ?

It's quite easy to reproduce:

Run the server
Create a new taxonomy that doesn't already exist
Click on the taxonomy link
Enjoy the 404
Restart the server
F5
Everything works

As I said, I'm pretty sure hugo is at fault here.

$ hugo version
Hugo Static Site Generator v0.54.0/extended linux/amd64 BuildDate: unknown

matalo33 · 2019-03-15T15:59:27Z

Works very well. I really like the styling of the nametag element on the content pages. I agree that the taxonomy page could use some more work. I am not a designer though :)

Some sample tag pages from other themes:
https://themes.gohugo.io//theme/hugo-theme-jane/categories/themes/
https://themes.gohugo.io//theme/hugo-flex/tags/shortcodes/
https://themes.gohugo.io//theme/hugo-w3-simple/tags/interesting/
https://themes.gohugo.io//theme/mero/tags/markdown

@pdelaby Please could you address the pull request feedback already provided?

we would show the number of pages with the tage ( "my first tag (8)", "my second tag (2)", but I don't know how to implement it.

Some of the examples above include this feature, however we can track this as a future improvement to get the feature released sooner than later.

matalo33 · 2019-03-25T16:33:01Z

Thanks for everything @pdelaby. If you could just get this branch rebased and ready for merge I'm happy to proceed.

pdelaby · 2019-03-25T20:09:31Z

Thanks :-)
So, just to be sure, the 4 commits on top of the updated master (upstream/master) ?

matalo33 · 2019-03-25T21:04:57Z

My bad, actually I could do this myself! Thanks again

pdelaby added 3 commits October 16, 2018 12:08

Displays tags on single (using header)

79a9777

Display tags list when clicking on tag

Display tags list

a75b1a0

Add documentation an theme variants

5f53dfa

matalo33 self-assigned this Dec 21, 2018

matalo33 added the enhancement Improvements to existing features label Dec 21, 2018

matalo33 added help wanted need user feedback feature New Features and removed enhancement Improvements to existing features labels Mar 13, 2019

matalo33 added this to the v2.3.0 milestone Mar 13, 2019

gilbsgilbs suggested changes Mar 13, 2019

View reviewed changes

PR#196 : Fix english typos and hide the 'tags' div when not needed

6207c44

gilbsgilbs approved these changes Mar 16, 2019

View reviewed changes

matalo33 merged commit 6207c44 into matcornic:master Mar 25, 2019

matalo33 removed help wanted need user feedback labels Mar 25, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added support for tags #196

Added support for tags #196

pdelaby commented Nov 29, 2018

gilbsgilbs commented Mar 13, 2019

matalo33 commented Mar 13, 2019

gilbsgilbs commented Mar 13, 2019

gilbsgilbs Mar 13, 2019

gilbsgilbs Mar 13, 2019

gilbsgilbs Mar 13, 2019

gilbsgilbs Mar 13, 2019

pdelaby Mar 14, 2019

gilbsgilbs Mar 14, 2019

gilbsgilbs Mar 13, 2019

gilbsgilbs Mar 13, 2019

pdelaby commented Mar 14, 2019

gilbsgilbs commented Mar 14, 2019

matalo33 commented Mar 15, 2019

matalo33 commented Mar 25, 2019

pdelaby commented Mar 25, 2019

matalo33 commented Mar 25, 2019

		## Behavior


		The tags are displayed at the top of the page, in the order wich they are enterted.

Added support for tags #196

Added support for tags #196

Conversation

pdelaby commented Nov 29, 2018

gilbsgilbs commented Mar 13, 2019

matalo33 commented Mar 13, 2019

gilbsgilbs commented Mar 13, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pdelaby commented Mar 14, 2019

gilbsgilbs commented Mar 14, 2019

matalo33 commented Mar 15, 2019

matalo33 commented Mar 25, 2019

pdelaby commented Mar 25, 2019

matalo33 commented Mar 25, 2019