[Patternlab, React] Fix footerlinks visual regression #1317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clairesunstudio
changed the title
ygannett
approved these changes
Dec 21, 2020
|
I can't replicate the latest 2 failed visual regression tests in patternlab https://35032-137521197-gh.circle-artifacts.com/0/backstop/reports/html/index.html |
clairesunstudio
deleted the
hotfix-react-patternlab-footerLinks-styles
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix FooterLinks visual regressions on develop in Patternlab:
https://app.circleci.com/pipelines/github/massgov/mayflower/1962/workflows/a83ac449-4a0e-480a-bb8f-7d1cbf1b59fe/jobs/35011/artifacts
This visual regression is due to the
ma__footer-links__itemsclass are attached to different containers in React and Patternlab. This PR adds a.ma__footer-links__navto the<nav>in FooterLinks and.ma__footer-links__itemsto<ul>in both React and Patternlab