Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assets/fix-ie-noto-loading-fallback #1311

Merged
merged 6 commits into from
Dec 19, 2020

Conversation

clairesunstudio
Copy link
Contributor

@clairesunstudio clairesunstudio commented Dec 16, 2020

Fixed:

Tested in IE11
Screen Shot 2020-12-16 at 3 47 13 PM

Copy link
Contributor

@tom-fleming tom-fleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@tom-fleming
Copy link
Contributor

tom-fleming commented Dec 17, 2020

@clairesunstudio The react/patternlab failures seem like minor differences with some text. Tried rerunning the tests to see if they clear up, but we might need to rebuild the references.

Copy link
Contributor

@tom-fleming tom-fleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patternlab/react tests failed after a rerun. I suggest we rebuild the references again in this case.

@clairesunstudio clairesunstudio merged commit cf9cc16 into develop Dec 19, 2020
@clairesunstudio clairesunstudio deleted the assets/fix-ie-noto-loading-fallback branch December 19, 2020 00:25
@clairesunstudio clairesunstudio mentioned this pull request Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants