Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1206 remove the node manager module from store #1208

Merged
merged 3 commits into from
Sep 29, 2023

Conversation

Thykof
Copy link
Contributor

@Thykof Thykof commented Sep 29, 2023

Delivery Quality Checklist

  • Breaking Changes in API:
    Does this PR introduce breaking changes in the API?

    • If yes, have you considered making it backward compatible?
    • If backward compatibility is not considered, set the "breaking-change" label.
  • Changelog:

    • For bugfix PR, set the "bugfix" label
    • If this change should not appear in changelog, use "ignore-for-changelog" label
  • Version Update Handling:
    Have you ensured that the version update by user is handled correctly?

  • PR Dependency:
    Does this PR depend on another PR?

    • If yes, is it necessary for the dependency to be released prior to merging this one?
  • Documentation:

    • Are any necessary changes made to user-facing documentation?
    • Confirm that API documentation is updated with any relevant changes.
    • Check that README and other documentation files are accurate and current.

@Thykof Thykof linked an issue Sep 29, 2023 that may be closed by this pull request
2 tasks
@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (34e46ea) 25.66% compared to head (369da89) 25.66%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1208   +/-   ##
=======================================
  Coverage   25.66%   25.66%           
=======================================
  Files          25       25           
  Lines        1535     1535           
=======================================
  Hits          394      394           
  Misses       1128     1128           
  Partials       13       13           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Thykof Thykof merged commit 7bec909 into main Sep 29, 2023
17 checks passed
@Thykof Thykof deleted the 1206-remove-the-node-manager-module-from-store branch September 29, 2023 17:21
@Thykof
Copy link
Contributor Author

Thykof commented Sep 29, 2023

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the Node Manager module from store
3 participants