Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buildnet WIP #4527

Merged
merged 24 commits into from
Nov 20, 2023
Merged

Buildnet WIP #4527

merged 24 commits into from
Nov 20, 2023

Conversation

Leo-Besancon
Copy link
Collaborator

  • document all added functions
  • try in sandbox /simulation/labnet
    • if part of node-launch, checked using the resync_check flag
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

Leo-Besancon and others added 12 commits November 8, 2023 16:06
@Leo-Besancon
Buildnet WIP
ff22cfd
@Eitu33
Test dir + base case test
0999669
@AurelienFT
Mock Final State/Improve tests execution (#4512)
5f56515 
* Use a controller for final state to be able to mock it

* Fix all formatting issues.

* Use more mocks in execution tests

* Fix test nested call usage

* improve some tests execution

* Fix tests async message and compact the test of executed

* Fix more execution tests

* Fix more tests.

* Update more tests

* Finish fixing all executions tests.

* Improve naming

* add more comment

* Fix comment
@Eitu33
Minor addition to test_standalone_selection
b5219cd
@Eitu33
Add test_invalid_roll_distribution
b9e4486
@Eitu33
Minor test_invalid_roll_distribution change
d1b83e0
@AurelienFT
fix clippy
a94e680
@sydhds
Fix double cursor advance (#4531)
2b3751a 
Co-authored-by: sydhds <[email protected]>
@Eitu33
Merge pull request #4529 from massalabs/pos-worker-tests
d899e8a 
Pos worker standalone test
@Leo-Besancon
Fix massa db change history handling (#4533)
b175e72 
* Initial fix and test

To check: if < or <= to allow changes

* fmt + clippy

* fix comments

* Remove debug prints

* Cache miss error rename + u8::MAX

* Added comments about Included and CacheMiss

* Comment + Add StreamingStep::Ongoing to test

* Fix previous tests
@dependabot
Bump self_cell from 1.0.1 to 1.0.2 (#4538)
650e2a0 
Bumps [self_cell](https://github.com/Voultapher/self_cell) from 1.0.1 to 1.0.2.
- [Release notes](https://github.com/Voultapher/self_cell/releases)
- [Commits](Voultapher/self_cell@v1.0.1...v1.0.2)

---
updated-dependencies:
- dependency-name: self_cell
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@aoudiamoncef
Add test code coverage + checksums (#4470)
350b2e6 
* ci: add test code coverage

* ci: add checksums to artifacts

* fix: cargo clean

* fix: trigger ci

* ci: last chance

* ci: skip macOS ...

* ci: silver bullet cache

* ci: add codecov

* ci: clean coverage utility

* ci: reset to main version
@codecov Codecov
Copy link

codecov bot commented Nov 16, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@dee3957). Click here to learn what that means.

❗ Current head f6720be differs from pull request most recent head 42fe539. Consider uploading reports for the commit 42fe539 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4527   +/-   ##
=======================================
  Coverage        ?   72.55%           
=======================================
  Files           ?      288           
  Lines           ?    50874           
  Branches        ?        0           
=======================================
  Hits            ?    36910           
  Misses          ?    13964           
  Partials        ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bilboquet and others added 12 commits November 16, 2023 17:01
@bilboquet
Keep only event count in ExecutionContextSnapshot
d054524 
Signed-off-by: Jean-François <[email protected]>
@damip
updates
44760cb
@damip
update packages
809ce7d
@Eitu33
make test_standalone_selection generic (#4539)
829a38f
@AurelienFT
Create universes for bootstrap (#4528)
861a3ce 
* Use a controller for final state to be able to mock it

* Fix all formatting issues.

* Use more mocks in execution tests

* Fix test nested call usage

* improve some tests execution

* Fix tests async message and compact the test of executed

* Fix more execution tests

* Fix more tests.

* Update more tests

* Finish fixing all executions tests.

* Improve naming

* Create universes for bootstrap

* add more comment

* Add bootstrap whitelist test correctly

* Update to make a correct bootstrap flow

* Change big bootstrap test and cleanup some unused variables

* Version of bootstrap tests with mock well organized

* Update bootstrap check database

* fix all tests bootstrap

* Fix tests massa db

* Update better tests

* modify condition
@damip
Fix readonly (#4543)
17af7bf 
* fix readonly

* update proto dep
@Leo-Besancon
Fix bootstrap deser (#4537)
f816173 
* Add length_value check in deserializer

* Update the logic

TODO:
- Fix UT fails
- Remove debug logs
- Refactor the serde of KV in a separate parser

* fmt

* Fix ser

* Remove prints

* Add duplicate key test in deserializer

* Add faulty message tests

* Fix & prints

* Update to take serialized len into account for streamBatch fill

* Rename + add comments

* Use Enum for faulty case instead of int
@Leo-Besancon
Fix clippy
9c55aad
@aoudiamoncef
Adjust node APIs settings (#4536)
bd89081 
* refactor: adjust APIs settings

* refactor: revert bind public address
@Eitu33
Improve ReadOnly estimations (#4545)
f6720be 
* Fix read only call & execution estimations

* Update comment
@bilboquet
Set async pool size to 1000 and add async msg fixed costs (#4546)
e9cb02e 
Signed-off-by: Jean-François <[email protected]>
@Leo-Besancon
Update genesis
42fe539
@Leo-Besancon Leo-Besancon marked this pull request as ready for review November 20, 2023 15:42
@Leo-Besancon Leo-Besancon requested a review from damip November 20, 2023 15:42
@damip damip merged commit 88cf02e into main Nov 20, 2023
4 of 13 checks passed
@bilboquet bilboquet deleted the buildnet_wip branch May 28, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damip damip Awaiting requested review from damip

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Leo-Besancon @damip @Eitu33 @AurelienFT @sydhds @aoudiamoncef @bilboquet