Add tests and rename handler and data #4421
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important description
This PR improves readability of the
AsyncMessage
structure, fix potential panics.Details :
Follow up that needs to be done
In GRPC :
On a more general note, I think we should make a changelog for the mainnet so that we could add breaking changes (but useful to be done now otherwise it will be a bigger mess) like this change and #4409 for example. @Leo-Besancon and @damip I let you decide on that.
The
messages.rs
file now have 90% of line coverage and all min/max limit on serializer/deserializer are tested