Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Robustify operations propagation #3086

Merged
merged 23 commits into from
Oct 3, 2022
Merged

Robustify operations propagation #3086

merged 23 commits into from
Oct 3, 2022

Conversation

gterzian
Copy link
Contributor

FIX #3054

@gterzian gterzian force-pushed the robustify_operations_propagation branch from 353dc93 to b2b2645 Compare September 28, 2022 08:26
@gterzian gterzian mentioned this pull request Sep 28, 2022
Closed
@gterzian gterzian force-pushed the robustify_operations_propagation branch 2 times, most recently from 6fdc21f to 3787f0a Compare September 28, 2022 08:28
@gterzian gterzian changed the base branch from main to prepare_testnet_15 September 29, 2022 09:12
@gterzian gterzian force-pushed the robustify_operations_propagation branch 2 times, most recently from ff846aa to bdc28b8 Compare September 29, 2022 09:18
@gterzian gterzian changed the base branch from prepare_testnet_15 to main September 29, 2022 09:18
@gterzian gterzian force-pushed the robustify_operations_propagation branch from bdc28b8 to f01ebca Compare September 29, 2022 09:18
@gterzian
Copy link
Contributor Author

@AurelienFT Could you please run the charge.py command with the simulator on this branch? I'm having some troubles installing it locally(see massalabs/massa-network-simulator#35). Thanks!

@gterzian gterzian force-pushed the robustify_operations_propagation branch 5 times, most recently from cab7ed1 to 5a81182 Compare September 30, 2022 09:29
@gterzian gterzian changed the base branch from main to prepare_testnet_15 September 30, 2022 09:36
@gterzian gterzian marked this pull request as ready for review September 30, 2022 09:38
@gterzian gterzian requested review from damip, AurelienFT and adrien-zinger and removed request for damip and AurelienFT September 30, 2022 09:47
@gterzian
Copy link
Contributor Author

@massalabs/core-team Ready for review.

Haven't been able to run the simulator yet(see the various issuesI filed), so if someone who has could run this on through it, it would be appreciated.

@gterzian gterzian requested a review from damip October 3, 2022 05:57
@gterzian gterzian force-pushed the robustify_operations_propagation branch from 6de3e12 to 836df1f Compare October 3, 2022 07:11
@gterzian
Copy link
Contributor Author

gterzian commented Oct 3, 2022

@AurelienFT @damip Thanks for the reviews, I think I have addressed all your comments. The protocol worker test suite passes, however I still haven't been able to run it on the simulator, and it doesn't look like I'll be able to for today.

@gterzian gterzian force-pushed the robustify_operations_propagation branch from ca2a947 to 60286ea Compare October 3, 2022 08:45
@damip
Copy link
Member

damip commented Oct 3, 2022

Ok, @sydhds can you take over for us to finish in time ?

@damip
Copy link
Member

damip commented Oct 3, 2022

@gterzian It's crucial that you figure out how to run the simulator, we can't go without it anymore. Let's make sure you have it for tomorrow, and open issues if anything goes wrong to get help until it works.

@damip damip merged commit 2d2765d into prepare_testnet_15 Oct 3, 2022
@AurelienFT AurelienFT deleted the robustify_operations_propagation branch May 29, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AurelienFT AurelienFT AurelienFT left review comments

@damip damip damip left review comments

@sydhds sydhds sydhds left review comments

@adrien-zinger adrien-zinger Awaiting requested review from adrien-zinger

Assignees

@sydhds sydhds

@gterzian gterzian

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Robustify endorsement/operation/block propagation for testnet 15
4 participants
@gterzian @damip @sydhds @AurelienFT