Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump(nil): update to 2023-08-09 #2492

Merged
merged 1 commit into from
Aug 19, 2023
Merged

bump(nil): update to 2023-08-09 #2492

merged 1 commit into from
Aug 19, 2023

Conversation

pimvh
Copy link
Contributor

@pimvh pimvh commented Aug 18, 2023

First of all, I am very happy with Mason. Thanks for this package!

I noticed that the Nil language for server is incompatible with newer versions of Nix. When building the version from Mason it fails. The fix incorporated in this newer version and should be backwards compatible. See oxalica/nil#93 for more context.

This also bumps to the latest version. There are more tags possible, I just picked the latest version of the language server. The tags are listed here: oxalica/nil/tags

EDIT: I see I mistakenly tagged a PR in my commit message 🙃, I'll edit that on merge.

The Nil language for server is incompatible with newer versions of Nix. When building the version from Mason it fails. The fix incorperated in this newer version should be backwards compatible. See oxalica/nil#93 for more context.

This also bumps to the latest version.
@williambotman williambotman requested a review from a team August 18, 2023 21:17
@pimvh pimvh changed the title Bump version of nil_ls language server (#1) Bump version of nil_ls language server Aug 18, 2023
Copy link
Member

@williamboman williamboman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! PRs are squash merged into a single commit, and I often update the commit message to follow the conventional commits format.

@pimvh
Copy link
Contributor Author

pimvh commented Aug 19, 2023

I think for test Package tests / Test packages (darwin_x64), we might be dependant on this upstream fix (cachix/install-nix-action#183). I just made a PR in the action repo to do a version bump mason-org/actions/pull/3.

With regards to the Linux tests (Package tests / Test packages (linux_x64) and Package tests / Test packages (linux_x64_gnu)), both give the same issue. It's unclear to me why this occurs, it might be related to how versioning is done in nil as in mason i always see it installing v0.0.0. Do you know the fix?

@williamboman
Copy link
Member

The version issue should be fixed in williamboman/mason.nvim#1459

@williamboman williamboman changed the title Bump version of nil_ls language server bump(nil): update to 2023-08-09 Aug 19, 2023
@williamboman williamboman enabled auto-merge (squash) August 19, 2023 11:40
@williamboman williamboman merged commit 1af0146 into mason-org:main Aug 19, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants