Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mailer-16: feat: add secrets invoke from aws secrets #22

Merged
merged 2 commits into from
May 28, 2024
Merged

Conversation

maskeynihal
Copy link
Owner

@maskeynihal maskeynihal commented May 28, 2024

This pull request primarily focuses on a shift in the way the application handles secrets, moving from a simple environment variable-based approach to utilizing AWS Secret Manager. The changes involve modifications to the configuration files, the introduction of new strategies for secret management, and adjustments to the mail service to accommodate these changes.

Key changes include:

Secret Management:

Configuration Changes:

Mail Service Adjustments:

@maskeynihal
Copy link
Owner Author

resolves #16

@maskeynihal
Copy link
Owner Author

closes #2

@maskeynihal maskeynihal merged commit a372bc6 into main May 28, 2024
2 checks passed
@maskeynihal maskeynihal deleted the Mailer-16 branch May 28, 2024 10:28
@maskeynihal maskeynihal linked an issue May 28, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add configuration for fetching secrets from AWS Secrets.
1 participant