Slightly refactor & add tests for API config loading & redis setup #151
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I really like I/O Docs, but the PRs I've submitted recently have been made a bit more nail-biting than necessary by the lack of tests. This PR adds some tests for a couple of (relatively trivial) areas of the code, and pulls those bits of code out into their own file.
This is obviously just a small start on a something bigger, but a) there's no reason it all needs to be done at once, and b) I wanted to check you're happy with this as a general approach.
I'd quite like to pull a few more bits out of app.js into their own testable modules (and put a few tests around some of them), and perhaps get some integration tests up and running (perhaps using supertest?) - would you be interested in more PRs along those lines?
Thanks,
Rowan