Update documentation and removed unneeded resource consumption #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masesdevelopers
added
documentation
masesdevelopers
deleted the
327-improve-kafka-streams-with-some-specific-knet-classes-7
branch
masesdevelopers
commented
Jan 23, 2024
Comment on lines
+90
to
+104
| if (!_keyStored) | ||
| { | ||
| if (_valueInner2 != null && _valueInner2.key != null) | ||
| { | ||
| var ll = _valueInner2.key; | ||
| _key = (TKey)(object)ll.LongValue(); | ||
| } | ||
| else | ||
| { | ||
| _keySerDes ??= _factory.BuildKeySerDes<TKey>(); | ||
| _key = _keySerDes.Deserialize(null, _valueInner1.key); | ||
| } | ||
| _keyStored = true; | ||
| } | ||
| return _key; |
There was a problem hiding this comment.
The logic done here can be applied to many other classes like the one managed from KNetConsumer e.g. KNetConsumerRecord
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Requests on properties of
KNetKeyValue,KNetTimestampedKeyValue,KNetTimestampedWindowedKeyValue,KNetWindowedKeyValueproduces results can be cached to avoid unneeded consumption of resources: data managed from the classes are immutable so does not change in their lifetime.Updated documentation of KNet Streams SDK.
Related Issue
fix #327
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: