Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove strong dependency from Windows types #6

Open
mariomastrodicasa opened this issue Feb 14, 2021 · 0 comments
Open

Remove strong dependency from Windows types #6

mariomastrodicasa opened this issue Feb 14, 2021 · 0 comments
Assignees
@mariomastrodicasa
Labels
C/C++ Related to C/C++ code Linux Related to Linux environment Windows Related to Windows environment

Comments

@mariomastrodicasa
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The actual implementation use Windows defined types. It is needed to remove this dependency before implements #5.

Describe the solution you'd like
Convert any Windows type (HRESULT, DWORD, and so on) in generic types. Maybe this types can be remapped on Windows types if we are running on Windows.

Describe alternatives you've considered
Use only generic types (int, int64, and so on) without any mapping.

Additional context
It is mandatory for issue #5.
@mariomastrodicasa mariomastrodicasa self-assigned this Feb 14, 2021
mariomastrodicasa added a commit that referenced this issue Mar 18, 2021
@mariomastrodicasa @github-actions
Updates and refininings on version 1.1 (#10)
aa6e5df 
* Fixed condition when channelName is NULL

* Update OpenDDS to version 3.16

* Added logs on CommonDataReaderListenerImpl callbacks

* Update OpenDDS to version 3.16: missing submodule change on previous commit

* #6: removed windows types from interfaces, moved thread/events/lock into support classes

* #6: added IDataDistributionChannel class to avoid generic void* for CHANNEL_HANDLE

* #6: removed unused header files and other direct windows API

* #7: updates on documentation

* Review of MastershipManager, moved outside main library, added parameter management

* Added MastershipConfiguration for configuration management

* Update behavior of create channel

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
@mariomastrodicasa mariomastrodicasa added C/C++ Related to C/C++ code Linux Related to Linux environment Windows Related to Windows environment labels Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mariomastrodicasa mariomastrodicasa

Labels
C/C++ Related to C/C++ code Linux Related to Linux environment Windows Related to Windows environment
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mariomastrodicasa