Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup 1.9.0 #701

Closed
rgoldberg opened this issue Jan 4, 2025 · 0 comments · Fixed by #702
Closed

Cleanup 1.9.0 #701

rgoldberg opened this issue Jan 4, 2025 · 0 comments · Fixed by #702
Assignees
@rgoldberg
Labels
🧹 cleanup Optimization of (not bug fix for) an existing feature
Milestone
1.9.0

Comments

@rgoldberg
Copy link
Contributor

rgoldberg commented Jan 4, 2025 •
edited
Loading

  • Improve mas config:
    • Reorder mas config output.
    • Set Package.installMethod from script/lint & script/test.
    • Simplify & consolidate sysctl value reading for mas config.
  • Improve Bug Report form text.
  • Only run CodeQL for the main branch.
@rgoldberg rgoldberg added the 🧹 cleanup Optimization of (not bug fix for) an existing feature label Jan 4, 2025
@rgoldberg rgoldberg added this to the 1.9.0 milestone Jan 4, 2025
@rgoldberg rgoldberg self-assigned this Jan 4, 2025
rgoldberg added a commit to rgoldberg/mas that referenced this issue Jan 4, 2025
@rgoldberg
Improve mas config:
54158a0 
- On Apple Silicon, output whether Rosetta is active.

- Reorder `mas config` output.

- Set `Package.installMethod` from `script/lint` & `script/test`.

- Consolidate `sysctl` value reading for `mas config`.

Resolve mas-cli#701

Signed-off-by: Ross Goldberg <[email protected]>
rgoldberg added a commit to rgoldberg/mas that referenced this issue Jan 4, 2025
@rgoldberg
Improve mas config:
8d12467 
- Reorder `mas config` output.

- Set `Package.installMethod` from `script/lint` & `script/test`.

- Consolidate `sysctl` value reading for `mas config`.

Resolve mas-cli#701

Signed-off-by: Ross Goldberg <[email protected]>
rgoldberg added a commit to rgoldberg/mas that referenced this issue Jan 4, 2025
@rgoldberg
Improve mas config:
942d2bb 
- Reorder `mas config` output.

- Set `Package.installMethod` from `script/lint` & `script/test`.

- Consolidate `sysctl` value reading for `mas config`.

Partial mas-cli#701

Signed-off-by: Ross Goldberg <[email protected]>
rgoldberg added a commit to rgoldberg/mas that referenced this issue Jan 4, 2025
@rgoldberg
Improve 01-bug-report.yml.
d5f4f50 
Resolve mas-cli#701

Signed-off-by: Ross Goldberg <[email protected]>
rgoldberg added a commit to rgoldberg/mas that referenced this issue Jan 4, 2025
@rgoldberg
Improve 01-bug-report.yml.
a092220 
Partial mas-cli#701

Signed-off-by: Ross Goldberg <[email protected]>
rgoldberg added a commit to rgoldberg/mas that referenced this issue Jan 4, 2025
@rgoldberg
Only run codeql.yml for the main branch.
6d4ccde 
Resolve mas-cli#701

Signed-off-by: Ross Goldberg <[email protected]>
@rgoldberg rgoldberg changed the title Improve mas config Cleanup 1.9.0 Jan 4, 2025
rgoldberg added a commit to rgoldberg/mas that referenced this issue Jan 4, 2025
@rgoldberg
Improve mas config:
6f7d6ac 
- Reorder `mas config` output.

- Set `Package.installMethod` from `script/lint` & `script/test`.

- Consolidate `sysctl` value reading for `mas config`.

Partial mas-cli#701

Signed-off-by: Ross Goldberg <[email protected]>
rgoldberg added a commit to rgoldberg/mas that referenced this issue Jan 4, 2025
@rgoldberg
Improve 01-bug-report.yml.
893edac 
Partial mas-cli#701

Signed-off-by: Ross Goldberg <[email protected]>
@rgoldberg rgoldberg mentioned this issue Jan 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rgoldberg rgoldberg

Labels
🧹 cleanup Optimization of (not bug fix for) an existing feature
Projects
None yet
Milestone
1.9.0
Development

Successfully merging a pull request may close this issue.

Cleanup 1.9.0 rgoldberg/mas
1 participant
@rgoldberg