Type improvements #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (interval) { | ||
| if (date) { | ||
| const { intervalESUnit, intervalESValue } = params as DateHistogramParams; | ||
| if ('interval' in params) { |
There was a problem hiding this comment.
This is simpler than casting 😄.
There was a problem hiding this comment.
Most important it's safer because Typescript infers the correct type on its own 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR looks good to me, I just had a bad feeling about some of the type casts - these can hide problems later when touching this code again. I went through the non-test files and tries to get rid of them.