Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect after login #300

Merged
merged 1 commit into from
Jun 9, 2023
Merged

Redirect after login #300

merged 1 commit into from
Jun 9, 2023

Conversation

marvinruder
Copy link
Owner

  • Redirect users to /login?redirect=… if any endpoint responds with specific 401 Unauthorized message
  • Redirect users to requested resource after login succeeds
  • Use /login?redirect=%2Fapi%2Fresource%2F… in Signal error messages with screenshot URL
  • Put error messages in commons package

* Redirect users to `/login?redirect=…` if any endpoint responds with specific 401 Unauthorized message
* Redirect users to requested resource after login succeeds
* Use `/login?redirect=%2Fapi%2Fresource%2F…` in Signal error messages with screenshot URL
* Put error messages in `commons` package
@marvinruder marvinruder added feature New feature or request frontend Related to frontend package backend Related to backend package commons Related to commons package labels Jun 9, 2023
@marvinruder marvinruder self-assigned this Jun 9, 2023
@marvinruder marvinruder linked an issue Jun 9, 2023 that may be closed by this pull request
3 tasks
@codacy-production
Copy link

Coverage summary from Codacy

Merging #300 (df09863) into main (0c67891) - See PR on Codacy

Coverage variation Diff coverage
+0.00% 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (0c67891) 8740 8740 100.00%
Head commit (df09863) 8740 (+0) 8740 (+0) 100.00% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#300) 5 5 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@marvinruder marvinruder merged commit 7a3f91c into main Jun 9, 2023
@marvinruder marvinruder deleted the 295-redirect-after-login branch June 9, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to backend package commons Related to commons package feature New feature or request frontend Related to frontend package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redirect after login
1 participant