Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor application #1528

Merged
merged 6 commits into from
Aug 28, 2024
Merged

Refactor application #1528

merged 6 commits into from
Aug 28, 2024

Conversation

marvinruder
Copy link
Owner

  • Migrate from express to hono
  • Restructure backend files similar to Nest.js
  • Use TypeScript strict mode and fix related issues
  • Use Zod and OpenAPI integration of Hono to validate requests and responses
  • Use typed Hono Client in frontend
  • Validate environment variables with Zod
  • Allow configuration of number of trusted proxies
  • Add security-related headers to all HTTP responses
  • Replace supertest instance with Hono and app.request

@marvinruder marvinruder added documentation Improvements or additions to documentation frontend Related to frontend package backend Related to backend package commons Related to commons package performance Improvement to performance technical Refactoring, code styling, logging, testing or other technical tasks labels Aug 28, 2024
@marvinruder marvinruder self-assigned this Aug 28, 2024
* Migrate from `express` to `hono`
* Restructure backend files similar to Nest.js
* Use TypeScript `strict` mode and fix related issues
* Use Zod and OpenAPI integration of Hono to validate requests and responses
* Use typed Hono Client in frontend
* Validate environment variables with Zod
* Allow configuration of number of trusted proxies
* Add security-related headers to all HTTP responses
* Replace `supertest` instance with Hono and `app.request`

Signed-off-by: Marvin A. Ruder <[email protected]>
Signed-off-by: Marvin A. Ruder <[email protected]>
Signed-off-by: Marvin A. Ruder <[email protected]>
Signed-off-by: Marvin A. Ruder <[email protected]>
Copy link

codacy-production bot commented Aug 28, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: +0.00%) 100.00% (target: 100.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (414aff7) 9812 9812 100.00%
Head commit (a6efb0e) 11618 (+1806) 11618 (+1806) 100.00% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1528) 8057 8057 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Signed-off-by: Marvin A. Ruder <[email protected]>
Signed-off-by: Marvin A. Ruder <[email protected]>
@marvinruder marvinruder merged commit 6fd1f77 into main Aug 28, 2024
10 checks passed
@marvinruder marvinruder deleted the refactor branch August 28, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to backend package commons Related to commons package documentation Improvements or additions to documentation frontend Related to frontend package performance Improvement to performance technical Refactoring, code styling, logging, testing or other technical tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant