Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sparklines #1312

Merged
merged 1 commit into from
May 22, 2024
Merged

Add sparklines #1312

merged 1 commit into from
May 22, 2024

Conversation

marvinruder
Copy link
Owner

  • Show sparkline in stock row, stock details with link to Yahoo Finance page
  • Save price information in database
  • Fetch currency, all price-related information from Yahoo Finance
  • Validate currency when fetching price targets
  • Document use of ticker as identifier for Yahoo Finance
  • Improve clearing fetched data from stocks
  • Allow not to send a Signal message when updating a stock
  • Improve comparing stock values for equality when updating
  • Harmonize fetching JSON from data providers
  • Escape URL parameters
  • Improve formatting of market capitalization, analyst information
  • Remove redundant eslint plugin fork
  • Fix issues with experimental linting rules for React Compiler

* Show sparkline in stock row, stock details with link to Yahoo Finance page
* Save price information in database
* Fetch currency, all price-related information from Yahoo Finance
* Validate currency when fetching price targets
* Document use of ticker as identifier for Yahoo Finance
* Improve clearing fetched data from stocks
* Allow not to send a Signal message when updating a stock
* Improve comparing stock values for equality when updating
* Harmonize fetching JSON from data providers
* Escape URL parameters
* Improve formatting of market capitalization, analyst information
* Remove redundant `eslint` plugin fork
* Fix issues with experimental linting rules for React Compiler

Signed-off-by: Marvin A. Ruder <[email protected]>
@marvinruder marvinruder added documentation Improvements or additions to documentation feature New feature or request frontend Related to frontend package backend Related to backend package commons Related to commons package data-provider Related to fetching data from providers labels May 22, 2024
@marvinruder marvinruder self-assigned this May 22, 2024
@marvinruder marvinruder linked an issue May 22, 2024 that may be closed by this pull request
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: +0.00%) 100.00% (target: 100.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (4aa3de4) 10850 10850 100.00%
Head commit (4308a4e) 10939 (+89) 10939 (+89) 100.00% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1312) 147 147 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

@marvinruder marvinruder merged commit 3c9acb7 into main May 22, 2024
11 checks passed
@marvinruder marvinruder deleted the 1235-add-sparklines branch May 22, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to backend package commons Related to commons package data-provider Related to fetching data from providers documentation Improvements or additions to documentation feature New feature or request frontend Related to frontend package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add sparklines
1 participant