Skip to content
This repository has been archived by the owner on May 5, 2024. It is now read-only.

chore: skip commit verification + bump @babel/* dependencies #642

Merged
merged 2 commits into from
Jun 13, 2023

Conversation

Enase
Copy link
Collaborator

@Enase Enase commented Jun 12, 2023

Changes:

  • deprecated actions/checkout git action updated
  • manual yarn-cache action replaced with actions/setup-node@v3 github action (cache configured)
  • Update Github Runner Node version and deprecate set-output message added to ignore list for commitlint (produced by Update Github Runner Node version and deprecate set-output #546)
  • @babel/* dependencies updated
  • prettier version updated
  • strict typescript version set in order to meet dependencies requirements

fixes: #546

@Enase Enase force-pushed the master branch 2 times, most recently from b10491f to 428e28a Compare June 12, 2023 23:34
@sbe-arg sbe-arg merged commit 0069027 into marvinpinto:master Jun 13, 2023
@sbe-arg
Copy link
Collaborator

sbe-arg commented Jun 13, 2023

thanks!

@sbe-arg
Copy link
Collaborator

sbe-arg commented Jun 13, 2023

Pre-release failed... unsure what the problem is here https://github.com/marvinpinto/actions/actions/runs/5249691334

@Enase
Copy link
Collaborator Author

Enase commented Jun 13, 2023

remote: Invalid username or password.

Investigating...

@sbe-arg
Copy link
Collaborator

sbe-arg commented Jun 13, 2023

I'm assuming a PAT token expired? GITHUB_SUPER_TOKEN? @marvinpinto otherwise there is no fix if we can't cross push. We need admin access to edit the child repos to allow this master repo to have actions native permissions instead of PAT.

looks like a block without marvin

@Enase
Copy link
Collaborator Author

Enase commented Jun 13, 2023

@sbe-arg @marvinpinto yes, it's a blocker, I cannot help here

@sbe-arg
Copy link
Collaborator

sbe-arg commented Jun 13, 2023

emailed @marvinpinto with details if there is no input we can probably fork everything in a new org with a few maintainers

@burtek
Copy link

burtek commented Jun 30, 2023

@sbe-arg any update?

@sbe-arg
Copy link
Collaborator

sbe-arg commented Jun 30, 2023

Because the cross repository sharing permissions are broken and can only be fixed by @marvinpinto we are limited in how to implement the builds.

I don't want to re engineer the flows much.
And this pr is sort of asking for a big re restructure now #675

I asked @Enase to disable linting wich is breaking the checks after each pr and each push to main

@Enase
Copy link
Collaborator Author

Enase commented Jun 30, 2023

@sbe-arg no reason to disable linters, just fix the issues and that's it. see the very last comment on PR

@sbe-arg
Copy link
Collaborator

sbe-arg commented Jun 30, 2023

Id prefer if we disable the linters for the commits altogether

@Enase
Copy link
Collaborator Author

Enase commented Jun 30, 2023

@sbe-arg If you disable the commit linter, it will prevent the automatic-releases plugin from generating the changelog correctly. it uses conventional-commits-parser

@Enase
Copy link
Collaborator Author

Enase commented Jun 30, 2023

@sbe-arg as a result we need to deal with changelog generation. release data wont include categorize "random" commits, see
https://github.com/marvinpinto/actions/releases

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants