fix: add error handling for when SSM secrets cannot be retrieved

marvinpinto · Sep 11, 2020 · 8c2a9ec · 8c2a9ec
1 parent 59093c3
commit 8c2a9ec
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 8 deletions.
diff --git a/packages/aws-ssm-secrets/README.md b/packages/aws-ssm-secrets/README.md
@@ -45,12 +45,12 @@ jobs:
           role-to-assume: "arn:aws:iam::111111111111:role/build-and-deploy-website"
           role-duration-seconds: 1800 # 30 mins
 
-      - uses: "marvinpinto/action-inject-ssm-secrets@v1"
+      - uses: "marvinpinto/action-inject-ssm-secrets@latest"
         with:
           ssm_parameter: "/build-secrets/${{ env.BUILD_STAGE }}/cloudflare-account-id"
           env_variable_name: "cloudflare_account_id"
 
-      - uses: "marvinpinto/action-inject-ssm-secrets@v1"
+      - uses: "marvinpinto/action-inject-ssm-secrets@latest"
         with:
           ssm_parameter: "/build-secrets/${{ env.BUILD_STAGE }}/cloudflare-api-token"
           env_variable_name: "cloudflare_api_token"

diff --git a/packages/aws-ssm-secrets/src/main.ts b/packages/aws-ssm-secrets/src/main.ts
@@ -29,12 +29,18 @@ export const main = async () => {
   const ssm = new SSM();
   core.startGroup('Injecting secret environment variables');
 
-  const result = await ssm
-    .getParameter({
-      Name: actionParam.ssmParameter,
-      WithDecryption: true, // NOTE: this flag is ignored for String and StringList parameter types
-    })
-    .promise();
+  let result;
+  try {
+    result = await ssm
+      .getParameter({
+        Name: actionParam.ssmParameter,
+        WithDecryption: true, // NOTE: this flag is ignored for String and StringList parameter types
+      })
+      .promise();
+  } catch (error) /* istanbul ignore next */ {
+    core.setFailed(error.message);
+    throw error;
+  }
 
   const envVar = actionParam.envVariable.toUpperCase();
   const secret = result?.Parameter?.Value;