Merge pull request #11 from welldsagl/feature/bug#10

Fix - Assets are uploaded as 34 byte

packages/automatic-releases/__tests__/assets/LICENSE

@@ -0,0 +1 @@
+this should not be overridden

packages/automatic-releases/__tests__/utils.test.ts

@@ -1,6 +1,6 @@
 import * as path from 'path';
 import fs from 'fs';
-import {generateChangelogFromParsedCommits} from '../src/utils';
+import {generateChangelogFromParsedCommits, octokitLogger} from '../src/utils';
 
 describe('changelog generator', () => {
   beforeEach(() => {
@@ -75,4 +75,33 @@ describe('changelog generator', () => {
     const result = generateChangelogFromParsedCommits(payload);
     expect(result.trim()).toEqual(expected.trim());
   });
+
+  it('log of input arguments should not overwrite the original args', () => {
+    const licenseFile = fs.readFileSync(path.join(__dirname, 'assets', 'LICENSE'), 'utf8');
+    const jarFile = fs.readFileSync(path.join(__dirname, 'assets', 'test.jar'), 'utf8');
+
+    const args = [
+      {
+        repoToken: 'repoToken',
+        automaticReleaseTag: 'automaticReleaseTag',
+        draftRelease: false,
+        preRelease: false,
+        releaseTitle: 'releaseTitle',
+        file: licenseFile,
+      },
+      {
+        repoToken: 'repoToken',
+        automaticReleaseTag: 'automaticReleaseTag',
+        draftRelease: false,
+        preRelease: false,
+        releaseTitle: 'releaseTitle',
+        file: jarFile,
+      },
+    ];
+
+    octokitLogger(...args);
+
+    expect(args[0].file).toEqual('this should not be overridden');
+    expect(args[1].file).toEqual('');
+  });
 });

packages/automatic-releases/src/utils.ts

@@ -168,15 +168,17 @@ export const octokitLogger = (...args): string => {
         return arg;
       }
 
+      const argCopy = {...arg};
+
       // Do not log file buffers
-      if (arg.file) {
-        arg.file = '== raw file buffer info removed ==';
+      if (argCopy.file) {
+        argCopy.file = '== raw file buffer info removed ==';
       }
-      if (arg.data) {
-        arg.data = '== raw file buffer info removed ==';
+      if (argCopy.data) {
+        argCopy.data = '== raw file buffer info removed ==';
       }
 
-      return JSON.stringify(arg);
+      return JSON.stringify(argCopy);
     })
     .reduce((acc, val) => `${acc} ${val}`, '');
 };