Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix declaration #2

Merged
merged 3 commits into from
Oct 10, 2019
Merged

Fix declaration #2

merged 3 commits into from
Oct 10, 2019

Conversation

ThomasBS
Copy link
Contributor

@ThomasBS ThomasBS commented Oct 9, 2019

Laravel version: 6.0.3

Will fix fatal error:

Declaration of MarvinLabs\DiscordLogger\LogHandler::write(array $record) must be compatible with Monolog\Handler\AbstractProcessingHandler::write(array $record): void

@vpratfr vpratfr changed the base branch from master to develop October 10, 2019 06:54
@vpratfr vpratfr merged commit b797323 into marvinlabs:develop Oct 10, 2019
@vpratfr
Copy link
Member

vpratfr commented Oct 10, 2019

Thanks. Released 1.1.1 with that fix.

@ThomasBS ThomasBS deleted the fix-declaration-for-write branch October 10, 2019 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThomasBS @vpratfr