Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing react-dom js #41

Merged
merged 3 commits into from
Jul 4, 2020
Merged

Fix missing react-dom js #41

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e66cff5
Fix missing react-dom js
chrisjsewell Jul 4, 2020
11cb5cc
determin python lib path dynamically
chrisjsewell Jul 4, 2020
e760626
add when clause
chrisjsewell Jul 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions tasks/aiida-core.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,24 @@

- meta: flush_handlers

# TODO this can be removed when aiida-core supports notebook>=6.0.1
# (which encorporates https://github.com/jupyter/notebook/pull/4772)
- name: Determine python lib path
when: '"notebook" in aiida_extras'
find:
path: "{{ aiida_venv }}/lib"
file_type: directory
patterns: "python*"
recurse: no
register: python_lib

- name: Fix missing react-dom js
when: '"notebook" in aiida_extras'
get_url:
url: https://unpkg.com/react-dom@16/umd/react-dom.production.min.js
dest: "{{ item }}/site-packages/notebook/static/components/react/"
with_items: "{{ python_lib.files | map(attribute='path') | list }}"

- name: "Activate TAB completion in virtualenv"
lineinfile:
path: "{{ aiida_venv }}/bin/activate"
Expand Down