Skip to content
This repository has been archived by the owner on Apr 16, 2022. It is now read-only.

- Adding support for AWS::Elasticsearch::Domain.EncryptionAtRestOptions #168

Conversation

rforte
Copy link
Contributor

@rforte rforte commented Jun 1, 2018

Currently, cfn-lint is unaware of the AWS::Elasticsearch::Domain property EncryptionAtRestOptions. This causes cfn-lint to output:

Resource: Resources > ElasticsearchDomain > Properties > EncryptionAtRestOptions
Message: EncryptionAtRestOptions is not a valid property of AWS::Elasticsearch::Domain
Documentation: http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-elasticsearch-domain.html

This PR adds this property to cfn-lint.

@martysweet
Copy link
Owner

Hi @rforte, thanks for contributing!

Please can you download the new US East (N. Virginia) CloudFormationResourceSpecification.json file available on the AWS CloudFormation Resource Specification page, that will update us to the latest spec for all resources (I believe there have been a few releases in the past week) and replace the specification file.
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/cfn-resource-specification.html

Please can you also remove the package-lock.json, it's something we are looking into but belongs on its own.

Thanks!
Marty

@rforte
Copy link
Contributor Author

rforte commented Jun 1, 2018

Will do. This tool is pretty damn helpful. Also, now the aws_resource_specification.json file in the repo makes waaaayyyy more sense to me that it came from AWS. Couldn't figure out the ordering of things when I modified it. You probably state how this all works in the README but I failed to investigate.

My bad on the lock file. Errantly staged.

- Updating AWS specification file
@martysweet martysweet added this to the v1.7.2 milestone Jun 2, 2018
@martysweet martysweet merged commit b55d3b6 into martysweet:master Jun 2, 2018
@martysweet
Copy link
Owner

Thanks @rforte, this is now available in v1.7.2!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants