Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issuing NICK during session breaks JOIN #93

Closed
toolness opened this issue Jun 27, 2012 · 1 comment · Fixed by #94
Closed

Issuing NICK during session breaks JOIN #93

toolness opened this issue Jun 27, 2012 · 1 comment · Fixed by #94

Comments

@toolness
Copy link
Contributor

When I issue a NICK command and later issue a JOIN command, the following exception is thrown:

node_modules/irc/lib/irc.js:549
                    throw err;
                          ^
TypeError: Cannot read property 'users' of undefined
    at Client.<anonymous> (/Users/atul/Documents/explorations/irc-fun/node_modules/irc/lib/irc.js:325:28)
    at Client.emit (events.js:88:20)
    at /Users/atul/Documents/explorations/irc-fun/node_modules/irc/lib/irc.js:546:22
    at Array.forEach (native)
    at Socket.<anonymous> (/Users/atul/Documents/explorations/irc-fun/node_modules/irc/lib/irc.js:543:15)
    at Socket.emit (events.js:67:17)
    at TCP.onread (net.js:362:31)

It looks like that's right here. The exception is being thrown because self.nick wasn't updated when the NICK command was issued.

toolness added a commit to toolness/steampunk that referenced this issue Jul 2, 2012
This is because my fork fixes martynsmith/node-irc#93. I will update
it to the npm version once that bug is officially resolved.
@micho
Copy link

micho commented Oct 22, 2012

Found this error too, the problem is indeed in that line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants