-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
copy-info: initial design doc #3574
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor stuff, as I'm no expert.
I do have one question though, will implicit tracking also be a future goal, where are plain mv/cp
in a jj
repo gets rewritten to a jj mv/cp
?
And a minor note on the title, if it only targets metadata it is fine. But if it also tackles #47 and #3386 then a better title would be "Copy info and Copy tracing Design" or "Copy Info and rename tracking for Jujutsu".
4a4cba8
to
477e237
Compare
477e237
to
a646cce
Compare
Partial reply; I haven't added anything for merge resolution yet, need to think about it for a while. |
cfd7e64
to
528f120
Compare
528f120
to
2e6ff94
Compare
@newren Hello Elijah, this may be of interest for you, would you mind taking a look at it? |
I renamed the doc and file name to better capture the 'tracking' aspect |
ec0fabb
to
75cf906
Compare
75cf906
to
a0e09a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good enough to start implementing. @fowles has already started working on it. Can we get an approval from a non-Googler? Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG
a0e09a7
to
a248ac3
Compare
Checklist
If applicable:
CHANGELOG.md