Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy-info: initial design doc #3574

Merged
merged 1 commit into from
Jun 24, 2024
Merged

copy-info: initial design doc #3574

merged 1 commit into from
Jun 24, 2024

Conversation

torquestomp
Copy link
Collaborator

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

@torquestomp torquestomp mentioned this pull request Apr 25, 2024
4 tasks
Copy link
Collaborator

@PhilipMetzger PhilipMetzger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor stuff, as I'm no expert.

I do have one question though, will implicit tracking also be a future goal, where are plain mv/cp in a jj repo gets rewritten to a jj mv/cp?

And a minor note on the title, if it only targets metadata it is fine. But if it also tackles #47 and #3386 then a better title would be "Copy info and Copy tracing Design" or "Copy Info and rename tracking for Jujutsu".

docs/design/copy-info.md Outdated Show resolved Hide resolved
docs/design/copy-info.md Outdated Show resolved Hide resolved
docs/design/copy-info.md Outdated Show resolved Hide resolved
docs/design/copy-info.md Outdated Show resolved Hide resolved
docs/design/copy-info.md Outdated Show resolved Hide resolved
docs/design/copy-info.md Outdated Show resolved Hide resolved
docs/design/copy-info.md Outdated Show resolved Hide resolved
docs/design/copy-info.md Outdated Show resolved Hide resolved
docs/design/copy-info.md Outdated Show resolved Hide resolved
docs/design/copy-info.md Outdated Show resolved Hide resolved
docs/design/copy-info.md Outdated Show resolved Hide resolved
docs/design/copy-info.md Outdated Show resolved Hide resolved
@torquestomp torquestomp force-pushed the dploch/copy-design branch from 477e237 to a646cce Compare May 1, 2024 19:20
@torquestomp
Copy link
Collaborator Author

Partial reply; I haven't added anything for merge resolution yet, need to think about it for a while.

docs/design/copy-info.md Outdated Show resolved Hide resolved
docs/design/copy-info.md Outdated Show resolved Hide resolved
docs/design/copy-info.md Outdated Show resolved Hide resolved
docs/design/copy-info.md Outdated Show resolved Hide resolved
docs/design/copy-info.md Outdated Show resolved Hide resolved
docs/design/copy-info.md Outdated Show resolved Hide resolved
docs/design/copy-info.md Outdated Show resolved Hide resolved
docs/design/copy-info.md Outdated Show resolved Hide resolved
docs/design/copy-info.md Outdated Show resolved Hide resolved
@torquestomp torquestomp force-pushed the dploch/copy-design branch 3 times, most recently from cfd7e64 to 528f120 Compare May 8, 2024 18:15
docs/design/copy-info.md Outdated Show resolved Hide resolved
@torquestomp torquestomp force-pushed the dploch/copy-design branch from 528f120 to 2e6ff94 Compare May 9, 2024 13:59
docs/design/copy-info.md Outdated Show resolved Hide resolved
@PhilipMetzger
Copy link
Collaborator

@newren Hello Elijah, this may be of interest for you, would you mind taking a look at it?

@torquestomp
Copy link
Collaborator Author

Just some minor stuff, as I'm no expert.

I do have one question though, will implicit tracking also be a future goal, where are plain mv/cp in a jj repo gets rewritten to a jj mv/cp?

And a minor note on the title, if it only targets metadata it is fine. But if it also tackles #47 and #3386 then a better title would be "Copy info and Copy tracing Design" or "Copy Info and rename tracking for Jujutsu".

I renamed the doc and file name to better capture the 'tracking' aspect

@torquestomp torquestomp force-pushed the dploch/copy-design branch 2 times, most recently from ec0fabb to 75cf906 Compare May 22, 2024 16:23
docs/design/copy-tracking.md Outdated Show resolved Hide resolved
docs/design/copy-tracking.md Outdated Show resolved Hide resolved
docs/design/copy-tracking.md Outdated Show resolved Hide resolved
docs/design/copy-tracking.md Show resolved Hide resolved
docs/design/copy-tracking.md Show resolved Hide resolved
docs/design/copy-tracking.md Show resolved Hide resolved
docs/design/copy-tracking.md Outdated Show resolved Hide resolved
docs/design/copy-tracking.md Outdated Show resolved Hide resolved
docs/design/copy-tracking.md Show resolved Hide resolved
@torquestomp torquestomp force-pushed the dploch/copy-design branch from 75cf906 to a0e09a7 Compare May 28, 2024 21:13
Copy link
Owner

@martinvonz martinvonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good enough to start implementing. @fowles has already started working on it. Can we get an approval from a non-Googler? Thanks

Copy link
Collaborator

@PhilipMetzger PhilipMetzger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@torquestomp torquestomp enabled auto-merge (rebase) June 24, 2024 17:17
@torquestomp torquestomp merged commit 1a78ba5 into main Jun 24, 2024
29 checks passed
@torquestomp torquestomp deleted the dploch/copy-design branch June 24, 2024 17:26
cenviity added a commit to cenviity/jj that referenced this pull request Jul 19, 2024
cenviity added a commit to cenviity/jj that referenced this pull request Jul 19, 2024
PhilipMetzger pushed a commit that referenced this pull request Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants