Develop 2.9 #38
Merged
Develop 2.9 #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tick extended due to overlap with core vnode_inactivity_timeout. Future overlap is possible, but is flagged in configuration comment. AAE only acts between primary vnodes, but this can be reverted to acting between fallbacks by switching the flag to off.
Currently certain unxpected events in prepare_put will cause the vnode to crash. It would be preferable to fail the PUT, but also log something out to offer a clue as to how these unexpected events are occurring. Ther eis a difficult balance here. Letting it crash prudces the crash log, which contains additional information about the request and the vnode state. However, this hasn't proven to be enough to resolve why this is occurring - so better now to gather some further information. Also, it is not clear if this issue could occurr with sufficient frequency to cause further problems due to continuous restart of the vnode. As the problem can't be recreated, the code branch is not tested. To provide some assurance it won't crash anyway, spec has been added to allow dialyzer to review.
Mas i1706 tictacprimary
If this issue cna occur with allow_mult=false, then potentially it could occur with allow_mult=true. This will prevent an empty PUT being added in both cases.
Develop 2.9
Develop 2.9
…bject i1707 merge fake object - log don't crash
Develop 2.9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update from develop