Skip to content

Commit

Permalink
fix some grammar and tests
Browse files Browse the repository at this point in the history
  • Loading branch information
martinscholz83 committed Jun 9, 2016
1 parent 8db1c10 commit ccd9654
Show file tree
Hide file tree
Showing 8 changed files with 15 additions and 10 deletions.
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
using Octokit;
using System;
using System;
using System.Diagnostics.CodeAnalysis;

namespace Octokit.Reactive
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ namespace Octokit.Reactive
public interface IObservableCommitCommentReactionsClient
{
/// <summary>
/// Creates a reaction for an specified Commit Comment
/// Creates a reaction for a specified Commit Comment
/// </summary>
/// <remarks>https://developer.github.com/v3/reactions/#create-reaction-for-a-commit-comment</remarks>
/// <param name="owner">The owner of the repository</param>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ namespace Octokit.Reactive
public interface IObservableIssueCommentReactionsClient
{
/// <summary>
/// Creates a reaction for an specified Issue Comment
/// Creates a reaction for a specified Issue Comment
/// </summary>
/// <remarks>https://developer.github.com/v3/reactions/#create-reaction-for-an-issue-comment</remarks>
/// <param name="owner">The owner of the repository</param>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ namespace Octokit.Reactive
public interface IObservableIssueReactionsClient
{
/// <summary>
/// Creates a reaction for an specified Issue.
/// Creates a reaction for a specified Issue.
/// </summary>
/// <remarks>https://developer.github.com/v3/reactions/#create-reaction-for-an-issue</remarks>
/// <param name="owner">The owner of the repository</param>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ public ObservableIssueCommentReactionsClient(IGitHubClient client)
}

/// <summary>
/// Creates a reaction for an specified Issue Comment
/// Creates a reaction for a specified Issue Comment
/// </summary>
/// <remarks>https://developer.github.com/v3/reactions/#create-reaction-for-an-issue-comment</remarks>
/// <param name="owner">The owner of the repository</param>
Expand All @@ -37,7 +37,7 @@ public IObservable<Reaction> Create(string owner, string name, int number, NewRe
}

/// <summary>
/// List reactions for an specified Issue Comment
/// List reactions for a specified Issue Comment
/// </summary>
/// <remarks>https://developer.github.com/v3/reactions/#list-reactions-for-an-issue-comment</remarks>
/// <param name="owner">The owner of the repository</param>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public async Task CanCreateReaction()

Assert.NotNull(issue);

var issueComment = await _issuesClient.Comment.Create(_context.RepositoryOwner, _context.RepositoryName, issue.Id, "A test comment");
var issueComment = await _issuesClient.Comment.Create(_context.RepositoryOwner, _context.RepositoryName, issue.Number, "A test comment");

Assert.NotNull(issueComment);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public async Task CanCreateReaction()

Assert.NotNull(issue);

var issueReaction = await _github.Reaction.Issue.Create(_context.RepositoryOwner, _context.RepositoryName, issue.Id, new NewReaction(ReactionType.Heart));
var issueReaction = await _github.Reaction.Issue.Create(_context.RepositoryOwner, _context.RepositoryName, issue.Number, new NewReaction(ReactionType.Heart));

Assert.NotNull(issueReaction);

Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
using Octokit;
using Octokit.Tests.Integration;
using Octokit.Tests.Integration.Helpers;
using System;
using System.Threading.Tasks;
using Xunit;

public class PullRequestReviewCommentReactionsClientTests
public class PullRequestReviewCommentReactionsClientTests : IDisposable
{
private readonly IGitHubClient _github;
private readonly IPullRequestReviewCommentsClient _client;
Expand Down Expand Up @@ -142,6 +143,11 @@ static void AssertComment(PullRequestReviewComment comment, string body, int pos
Assert.Equal(position, comment.Position);
}

public void Dispose()
{
_context.Dispose();
}

class PullRequestData
{
public int Number { get; set; }
Expand Down

0 comments on commit ccd9654

Please sign in to comment.