Testbed: Create "bus" and "class" dirs at init #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libudev expects the "bus" and "class" directories to exist when calling udev_enumerate_scan_devices(). When this was called on an empty Testbed, it would return -ENOENT since these directories did not exist. This fixes the issue by creating the "/sys/bus" and "/sys/class" at the same time that "/sys" is created in the Testbed. num_udev_devices() is modified to call udev_enumerate_scan_devices() directly instead of using GUdev, which ignores the return value of udev_enumerate_scan_devices(). This makes t_testbed_empty() a valid test for the bug we are fixing. Some vala tests also had to be modified to account for the change. Fixes: martinpitt#144
martinpitt
approved these changes
Sep 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libudev expects the "/sys/bus" and "/sys/class" directories to exist when calling
udev_enumerate_scan_devices(). When this was called on an emptyTestbed, it would return-ENOENTsince these directories did not exist.This fixes the issue by creating the "/sys/bus" and "/sys/class" directories at the same time that "/sys" is created in the
Testbed.num_udev_devices()is modified to calludev_enumerate_scan_devices()directly instead of using GUdev, which ignores the return value ofudev_enumerate_scan_devices(). This makest_testbed_empty()a valid test for the bug we are fixing.Some vala tests also had to be modified to account for the change.
Fixes: #144