Build failing when using meson 1.4.0rc1

[DimStar77]

In order to test the impact of Meson 1.4.0 , I upgraded a test repository of openSUSE Tumbleweed to this new version,

Out of the builds, umockdev is failing (seems its failing similar to what that HACK commit addresses, which was done in Gentoo? Did Gentoo update to a 1.4 pre-release of meson?)

I get plenty of these errors:

[   12s] umockdev-record.p/src/umockdev-record.c:1141:22: error: unused variable ‘_line_collection_size_’ [-Werror=unused-variable]
[   12s]  1141 |                 gint _line_collection_size_ = 0;
[   12s]       |                      ^~~~~~~~~~~~~~~~~~~~~~

Simply going back to meson 1.3.2 makes umockdev build pass (CC @jpakkane / meson release maintainer)

(full build log can be found at https://build.opensuse.org/build/GNOME:Next/openSUSE_Factory/x86_64/umockdev/_log )

[DimStar77]

git bisected this on the meson side to mesonbuild/meson@5f659af - aka mesonbuild/meson#12597

[martinpitt]

Oooh thanks @DimStar77 for figuring that out! 💯 I first saw this in the Gentoo build, and suspected gcc 14 or related, but couldn't find a meaningful difference. So I applied commit 539af0b.

So I suppose that should just become the new default. This makes sense at last!

[DimStar77]

I first saw this in the Gentoo build, and suspected gcc 14 or related, but couldn't find a meaningful difference.

gentoo backported that vala fix from meson 1.4 into their package with gentoo/gentoo#34141

[DimStar77]

So I suppose that should just become the new default. This makes sense at last!

on openSUSE, I added this to umockdev.spec:
export CFLAGS="-Wno-error=unused-function -Wno-error=unused-value -Wno-error=unused-variable %{optflags}"

[thesamesam]

By the way, feel free to CC me if there's anything like this which shows up for Gentoo which I might be able to give insight on. Happy to help!

[martinpitt]

Thanks @thesamesam It seems to be quite happy now, aside from the ugliness of #226.. (but that's not Gentoo specific at all).