#334 Refactor Branch admin deleting #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viliambalaz
commented
Apr 16, 2021
| if obj is None: | ||
| return True | ||
| return not obj.is_main | ||
| def delete_constraints(self, obj): |
There was a problem hiding this comment.
@martinmacko47 Nie je to uplne potrebne, ale chcel som to spravit rovnako ako v Action. Potom ked spravim admin mazanie pre vsetky instancie, a tie casti kodu, ktore sa opakuju by som dal do spolocnej classy. Rovnako aj template.
There was a problem hiding this comment.
Ano, bolo by dobre spravit casom nejaky mixin, napriklad DeleteConstraintsAdminMixin, ktory definuje prazdnu abstraktnu metodu delete_constraints a pouzije ju v render_delete_form a delete_model, nech netreba tu logiku opakovat.
|
@viliambalaz V dalsom PR asi teraz skus spravit hromadne mazania |
martinmacko47
approved these changes
Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.