Use separate prop-types package for compatibility with react16+

[chpill]

Using this library issues a warning regarding the fact that PropTypes will need to be accessed from a separate package starting with react16.

The version of the cljsjs/prop-types library used is the one recommended in the rum readme

[martinklepsch]

Thanks @chpill, that's a good catch. Is this backwards compatible with React 15?

[chpill]

It should be, the prop-types package is strictly equivalent to what was included with react until v16.

That said, I have only tested it with react16 (using some exclusions and this fork of rum )... I'll try to make use of this in other projects using react v15 to see if I see some breakage, but it is quite painful to test unreleased features of external libraries using lein or boot...

I'll try make use of the :local/root feature of the deps.edn used by the new clojure CLI and report back.

[chpill]

Just tested locally, works like a charm with react v15.4.2

[martinklepsch]

@chpill I just cut a release: 0.3.0. It has a breaking change but since you already tested it with your change I assume you did not use derivatives-pool directly.

As usual details can be found in the changelog.

[chpill]

@martinklepsch Thanks a lot for the new release! I am in fact using derivatives-pool directly, but I was already using the latest version of the code (with the derivatives-pool record), so it's all good 👍

I have ditched using react context because i found it too cumbersome... In the end I use derivatives in combinations with citrus, i pass my reconciler around and keep the derivatives-pool in it.

I also made a mixin that registers and releases derivatives during :render, a bit like the rum.core/reactive mixin, so that I don't have to declare what derivatives I am going to use beforehand.

[martinklepsch]

That sounds cool, if you feel like sharing maybe that would be a nice addition to the readme?

…

On Wed 17. Jan 2018 at 09:49, chpill ***@***.***> wrote: @martinklepsch <https://github.com/martinklepsch> Thanks a lot for the new release! I am in fact using derivatives-pool directly, but I was already using the latest version of the code (with the derivatives-pool record), so it's all good 👍 I have ditched using react context because i found it too cumbersome... In the end I use derivatives in combinations with citrus <https://github.com/roman01la/citrus>, i pass my reconciler around and keep the derivatives-pool in it. I also made a mixin that registers and releases derivatives during :render, a bit like the rum.core/reactive mixin, so that I don't have to declare what derivatives I am going to use beforehand. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#18 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAF82HbQkU0dLlRy7Wr_77pTTg2G8s3pks5tLbQwgaJpZM4RfpXW> .

[chpill]

Sure, should I open a new issue to start the discussion?

[martinklepsch]

Feel free to go straight to PR. I think the usage section could be split in the following ways:

• usage
  • generic (i.e. no specific react wrapper)
  • rum
  • citrus

If there are larger code blogs you could consider using <details></details> to hide them at first.

[chpill]

I'll try to contribute something soon. I have to clean up the way I initialize the whole thing before I can show it to other people 😅