Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve handling of identity or constant mass matrix #37

Closed
martinjrobins opened this issue Apr 20, 2024 · 0 comments · Fixed by #38
Closed

improve handling of identity or constant mass matrix #37

martinjrobins opened this issue Apr 20, 2024 · 0 comments · Fixed by #38
Labels
optimisation improves the efficiency of the solvers

Comments

@martinjrobins
Copy link
Owner

mass matrix currently implemented via an implicit function $Mv$, for a large majority of cases $M=I$ or $M$ is constant, so I think we need to factor in efficiencies for these cases

  • Should the solvers be aware if $M=I$ or not and act accordingly? Or should the efficiencies be implemented in OdeEquations?
  • for the latter above, should OdeEquations provide a gemv style function for the implicit solvers to use?
  • and an $M^{-1}$ function for the explicit solvers?
@martinjrobins martinjrobins added enhancement New feature or request optimisation improves the efficiency of the solvers and removed enhancement New feature or request labels Apr 20, 2024
martinjrobins added a commit that referenced this issue Apr 20, 2024
martinjrobins added a commit that referenced this issue Apr 21, 2024
martinjrobins added a commit that referenced this issue Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
optimisation improves the efficiency of the solvers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant