Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While developing
hyper-dns
I noticed a two things that were problematic:dnslink
here that uses_dnslink.<name>
to look up names initially instead of<name>
to supportCNAME
andALIAS
entries on the main entry. This proposal prefixes domains withhyper-dns
because - unfortunately -dnslink
's implementations don't support multiplednslink=
text entries per domain. I am not sure how important a fallback to<name>
really is, ifhyper-dns.<name>
is given?dat
without doing a https request. The vast majority of domains out there do not supportdat
and looking up those domains may make us seem like a bad actor. The solution proposed in this PR is to only usewell-known
lookups if a special key is set, specificallyhyper=well-known
.