Detect IEnumerable<KeyValuePair<string, object>> in log scopes

[gkinsman]

This PR implements a potential solution from issue #214.

Instead of rendering => System.Collections.Generic.KeyValuePair2[System.String,System.Object][] for scope objects of this type, it renders this:

[2018-08-19 16:12:16Z] info: MyName[0]
      => ScopeKeyOne: ScopeValueOne
      => ScopeKeyTwo: ScopeValueTwo
      => ScopeKeyThree: ScopeValueThree
        => ScopeKeyFour: ScopeValueFour
        => ScopeKeyFive: ScopeValueFive
        => ScopeKeySix: ScopeValueSix
      Message|False|False

given this log message:

using (logger.BeginScope(new[]
{
    new KeyValuePair<string, object>("ScopeKeyOne", "ScopeValueOne"),
    new KeyValuePair<string, object>("ScopeKeyTwo", "ScopeValueTwo"),
    new KeyValuePair<string, object>("ScopeKeyThree", "ScopeValueThree"),
}))
{
    using (logger.BeginScope(new[]
    {
        new KeyValuePair<string, object>("ScopeKeyFour", "ScopeValueFour"),
        new KeyValuePair<string, object>("ScopeKeyFive", "ScopeValueFive"),
        new KeyValuePair<string, object>("ScopeKeySix", "ScopeValueSix"),
    }))
    {
        logger.Log<string>(LogLevel.Information, 0, null, null, Formatter);
    }
}

[codecov]

Codecov Report

Merging #215 (2d38c4e) into main (6a2f6c5) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #215      +/-   ##
==========================================
+ Coverage   99.05%   99.12%   +0.06%     
==========================================
  Files           8        8              
  Lines         319      342      +23     
==========================================
+ Hits          316      339      +23     
  Misses          3        3              

Flag	Coverage Δ
linux	98.24% <100.00%> (-0.82%)	⬇️
macos	99.12% <100.00%> (+0.06%)	⬆️
windows	99.12% <100.00%> (+0.06%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/Logging.XUnit/XUnitLogScope.cs	100.00% <100.00%> (ø)
src/Logging.XUnit/XUnitLogger.cs	98.05% <100.00%> (+0.32%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a2f6c5...2d38c4e. Read the comment docs.

[martincostello]

Could you also augment one of the new tests you've added with a scope that gets it to hit the uncovered block please?

[gkinsman]

Could you also augment one of the new tests you've added with a scope that gets it to hit the uncovered block please?

Sure thing! I added a new test as having a scope type of IEnumerable<string> is different enough.

[martincostello]

Thanks for the PR George!

If you want to give it a whirl from MyGet to just check it's all working as you'd expect, then I'll push 0.1.1 to NuGet.org.

https://www.myget.org/feed/martincostello/package/nuget/MartinCostello.Logging.XUnit/0.1.1-beta0189

[gkinsman]

Thanks for the PR George!

If you want to give it a whirl from MyGet to just check it's all working as you'd expect, then I'll push 0.1.1 to NuGet.org.

https://www.myget.org/feed/martincostello/package/nuget/MartinCostello.Logging.XUnit/0.1.1-beta0189

Perfect, was just wondering where I might get it from 😁. Will let you know how it goes! Thanks!

[gkinsman]

So as I think you saw, it works well! Happy for you to push to nuget 🙂

[martincostello]

Done! 🚀 https://www.nuget.org/packages/MartinCostello.Logging.XUnit/0.1.1

[gkinsman]

Done! 🚀 https://www.nuget.org/packages/MartinCostello.Logging.XUnit/0.1.1

Thanks very much!