-
-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JSON log parser #179
Add JSON log parser #179
Conversation
Thanks for the PR! As already said, 👍 on the general design. Will review in detail ASAP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for taking so long. A big 👍 in general on this change; I've just added a few notes and thoughts -- let me know what you think. ;)
Fixed some grammatical errors. Co-authored-by: Martin Helmich <[email protected]>
Use the assertions of testify package. Co-authored-by: Martin Helmich <[email protected]>
Optimize performance. Co-authored-by: Martin Helmich <[email protected]>
Use the testify package.
I'm not a GitHub expert. I should also modify textparser_test.go and loader_flags.go. Should I make all the modifications above in my local repo and commit once and push again, or some other operations? Please give me some advice. |
Just commit as it is most convenient for you 😄 -- I'll probably squash the entire branch into a single commit when merging, anyway, so you don't need to do any Git history rewrites or any such things before pushing. |
2. Use testify package in parser/*._test file.
Code Climate has analyzed commit 4348122 and detected 0 issues on this pull request. View more on Code Climate. |
[FEATURE] Add JSON parser to support JSON log files
Fixes: #793
I've made various changes:
Bump the Go version to 1.13 in Dockerfile
Add a new flag and config-file argument "-parser"
Abstract a generic
Parser
interfaceProvide two implementations of
Parser
interface: plain text parserTestParser
and JSON parserJsonParser
Very welcome to propose improvements to the code.