Add relabeling setting to add label only to response count metric #128
Conversation
|
There has not been any activity to this pull request in the last 30 days. It will automatically be closed after 7 more days. Remove the |
|
No, not |
There was a problem hiding this comment.
Finally getting to this, sorry for the long wait 🙄
👍 in general from me. I've made a suggestion for a tiny possible optimization. Also, could you possibly add some tests for this feature? I personally don't have any use case for this feature and probably won't notice if I accidentally break it in future releases. 🤷
Dynamic relabeling can potentially result in a lot of time series being collected, especially related to the response and upstreams time histograms. This change is intended to allow collecting more detailed information on response count without the side effect of adding more dimensions to the other metrics.
stempler
force-pushed
the
feat/counter-only-relabels
branch
from
f3f2c94 to
3c90389
Compare
|
Code Climate has analyzed commit 3c90389 and detected 0 issues on this pull request. View more on Code Climate. |
|
There has not been any activity to this pull request in the last 30 days. It will automatically be closed after 7 more days. Remove the |
|
Sorry for the lack of attention. I'll give this PR another look shortly. |
|
Finally got around to have a detailed look at this -- merged 🎉 (I pushed a few minor nitpicks on top of your branch myself). 👍 Thanks for the contribution and again sorry for the wait. |
Dynamic relabeling can potentially result in a lot of time series being collected, especially related to the response and upstreams time histograms.
This change is intended to allow collecting more detailed information on response count without the side effect of adding more dimensions to the other metrics.
I hope this is something that you may find useful. Basically my first time writing any Go code, so you are very welcome to propose improvements to the code.