Set default space type to L2 to support bwc (opensearch-project#267)

This change adds L2 space type fall back during query. This prevents backwards compatibility issues for clusters upgrading from ES 7.1 and 7.4. In those versions, space type was not introduced as a field attribute yet. Signed-off-by: John Mazanec <[email protected]>
martin-gaievski · Jan 26, 2022 · 54969f0 · 54969f0
1 parent 0258415
commit 54969f0
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/main/java/org/opensearch/knn/index/KNNWeight.java b/src/main/java/org/opensearch/knn/index/KNNWeight.java
@@ -110,7 +110,8 @@ public Scorer scorer(LeafReaderContext context) throws IOException {
             } else {
                 String engineName = fieldInfo.attributes().getOrDefault(KNN_ENGINE, KNNEngine.NMSLIB.getName());
                 knnEngine = KNNEngine.getEngine(engineName);
-                spaceType = SpaceType.getSpace(fieldInfo.getAttribute(SPACE_TYPE));
+                String spaceTypeName = fieldInfo.attributes().getOrDefault(SPACE_TYPE, SpaceType.L2.getValue());
+                spaceType = SpaceType.getSpace(spaceTypeName);
             }
 
             /*