Fix for adding CSS when CDN specified #347
Conversation
|
Michael Haitz » wicket-bootstrap #831 UNSTABLE |
| @@ -35,6 +36,9 @@ public void renderHead(final IBootstrapSettings settings, final IHeaderResponse | |||
| super.renderHead(settings, headerResponse); | |||
|
|
|||
| // just includes all bootstrap resource references. | |||
| //adds the ccss header reference item. Makes sure that the CSS has been added if specified by CDN | |||
| final CssReferenceHeaderItem cssReferenceHeaderItem = CssReferenceHeaderItem.forReference(settings.getCssResourceReference(), "screen"); | |||
| headerResponse.render(cssReferenceHeaderItem); | |||
There was a problem hiding this comment.
this is done by BootstrapBaseBehavior.
public void renderHead(final IBootstrapSettings settings, final IHeaderResponse headerResponse) {
final ITheme theme = settings.getActiveThemeProvider().getActiveTheme();
theme.renderHead(headerResponse);
}
|
the bug is located in How do you initialize bootstrap? |
|
It seems I have broken BootstrapTheme CDN support with:
For some reason (that I cannot recall now) I have commented out the override of |
|
But it seems to be fixed with 61276c3 |
|
@martin-g and @l0rdn1kk0n This seems to fail see #345 it adds a blank CSS at the top with no href value. If this is due to the default theme not being set then that is different. The code change adds the CSS reference as per your commit above with this change. |
|
We concluded that there is no issue in #345. Closing this issue as well. |
This fixed the issue of the CSS not being added when uising CDN.