-
-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle need restart after installation for winget #626
Conversation
c204aee
to
fec96df
Compare
Instead of showing a dialog, what do you think about showing only a push notification, with the globals.trayIcon.showMessage function? |
I think this dialogs might be a little bit intrusive, especially when bulk-updating packages |
I agree, but now, show "error" dialog. Should I just rewrite it in a text message like "installed successfully"? |
The current behaviour is:
What I would do is change the text of that "{0} installation succeeded" for "A restart is required to finish {0} installation", as well as addding a visual indicator in the ui telling the user to restart its PC. If you don't understand how the error message class works, (it is a little bit messy), just let me know and I'll implement this feature. Don't worry for the visual indicator, since I am working on a base class for them, since I need to implement one for one of the chocolatey features. |
ca17bb5
to
c80a21c
Compare
Done, new strings:
Code is now more "simplify". |
3f09fe7
to
a419e59
Compare
a419e59
to
9b6befa
Compare
#625
Added some new texts, but question is, are we really need dialog?
@marticliment