Create .deepsource.toml, .whitesource, and Update WebBasedData/test_urls.py #2653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marticliment, please review this and give some suggestions. |
|
please do not autoformat code |
Co-authored-by: mend-bolt-for-github[bot] <42819689+mend-bolt-for-github[bot]@users.noreply.github.com>
skanda890
changed the title
skanda890
changed the title
Co-authored-by: Excel Bot <[email protected]>
|
@marticliment, any more suggestions? |
To check if a variable is equal to one of many values, combine the values into a tuple and check if the variable is contained `in` it instead of checking for equality against each of the values. This is faster, less verbose, and more readable. Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
skanda890
changed the title
|
Why the refractoring? |
|
What do this files ( .deepsource.toml, .whitesource) do? |
To check if a variable is equal to one of many values, combine the values into a tuple and check if the variable is contained |
These files configure security bots like MendBolt and DeepSource. |
|
@marticliment, please accept or deny this as soon as possible as I am deleting all my forked repositories. |
|
Give me one week |
Co-authored-by: Excel Bot <[email protected]>
marticliment
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any user suspected of farming GitHub activity with crypto purposes will get banned. Submitting broken code wastes the contributors' time, who have to spend their free time reviewing, fixing, and testing code that does not even compile breaks other features, or does not introduce any useful changes. Thank you for your understanding.
Create .deepsource.toml and .whitesource to check for security issues and more.