Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Identify MSStore packages on the install section #502

Closed
ppvnf opened this issue Dec 16, 2022 · 12 comments
Closed

[FEATURE REQUEST] Identify MSStore packages on the install section #502

ppvnf opened this issue Dec 16, 2022 · 12 comments
Assignees
Labels
new-feature A new feature that could be useful in WingetUI ready-to-go

Comments

@ppvnf
Copy link
Contributor

ppvnf commented Dec 16, 2022

I know Winget-CLI ability to identify source as MSStore is broken, however I believe there's a relatively simple way this can be achieved by WingetUI. This is because MSStore packages end with an underscore and exactly 13 characters after it. For example:

JAMSoftware.TreeSizeFreePrivate_37s2tpab2h9zg
8bitSolutionsLLC.bitwardendesktop_h4e712dmw3xyy

@ppvnf ppvnf added the new-feature A new feature that could be useful in WingetUI label Dec 16, 2022
@marticliment
Copy link
Owner

Oh, you mean like treating them as winget packages (showing info, etc.)?

@ppvnf
Copy link
Contributor Author

ppvnf commented Dec 16, 2022

Oh, you mean like treating them as winget packages (showing info, etc.)?

That would be nice, but I was only thinking about them having a different icon from Local PC and regular Winget so I could easily differentiate the source

@ppvnf
Copy link
Contributor Author

ppvnf commented Dec 19, 2022

I think 2d61f53 made MSStore packages appear as Winget ones, but I don't think WingetUI is able to display any info about them (because it's not available through Winget). Then maybe it doesn't make sense to have show info for these packages

Icon suggestion to differentiate MSStore from Winget source:


https://img.icons8.com/ios/512/shopping-bag--v1.png

@marticliment
Copy link
Owner

image

@ppvnf
Copy link
Contributor Author

ppvnf commented Dec 19, 2022

I appreciate your attempt, but it's not working properly.

  1. This package for some reason is misidentified as being from MSStore (it's from Winget actually). I believe the reason is the hyphen:
    Captura de tela 2022-12-19 161229

  2. These ones are working fine:
    Captura de tela 2022-12-19 162727

  3. Several packages that are actually from MSStore appear as Winget packages (I believe the reason is the ellipsis):

Captura de tela 2022-12-19 162853

marticliment added a commit that referenced this issue Dec 19, 2022
@marticliment
Copy link
Owner

Regarding the ellipsis, this is the same issue as always. Microsoft messing up, and much can't be done about it.

@ppvnf
Copy link
Contributor Author

ppvnf commented Dec 19, 2022

The problem isn't the ellipsis itself, but because of it 16 out of 19 MSStore packages are wrongly identified as Winget pkgs. Only 3 are correctly identified as being from MSStore. Is there a way to ignore the ellipsis only during the source check?

@marticliment
Copy link
Owner

I mean, i could omit it, but the 13-character id wouldn't be 13 characters long.

@marticliment
Copy link
Owner

However, i could actually fix that

@marticliment marticliment reopened this Dec 19, 2022
@ppvnf
Copy link
Contributor Author

ppvnf commented Dec 19, 2022

Thanks for fixing Micrisoft's problems ahead of time! I don't know if you have a better idea, but I've noticed that packages with _ that have ... are from MSStore. The only exceptions are packages that have { (but they aren't detected as Winget, so it's probably not a problem)

Captura de tela 2022-12-19 182530

@marticliment
Copy link
Owner

It should be now working

@ppvnf
Copy link
Contributor Author

ppvnf commented Dec 20, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature A new feature that could be useful in WingetUI ready-to-go
Projects
None yet
Development

No branches or pull requests

2 participants