Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3.13 #982

Merged
merged 1 commit into from
Nov 2, 2024
Merged

Support Python 3.13 #982

merged 1 commit into from
Nov 2, 2024

Conversation

lafrech
Copy link
Member

@lafrech lafrech commented Oct 17, 2024

No description provided.

@lafrech
Copy link
Member Author

lafrech commented Oct 17, 2024

Fails with falcon on 3.13.

No rush. Let's wait for Falcon 4.0 to ship. A RC has been published two days ago.

@sirosen
Copy link
Collaborator

sirosen commented Oct 17, 2024

Yeah, I'm cool with that. For the record, I have a pretty good guess about the build failure.

For some reason, setuptools is failing to pick up the falcon.__version__ attribute when building.
But also, I notice that their build uses Cython, so I bet it's a complex build process and not perfectly captured by the [build-system] table.

I'm betting that for all of the older Python versions, we've been getting wheels for falcon, but that there is no 3.13 wheel. That would mean this is the first time we've hit a requirement to build from sdist, and it doesn't work smoothly.

@sirosen
Copy link
Collaborator

sirosen commented Oct 22, 2024

I was doing some personal cleanup and saw that this was still in my queue to handle. Falcon 4.0 is out, so I figured I should rerun CI and probably merge this.

Unfortunately, there's a new and different failure to handle, and we'll probably be best served waiting for this one as well.

3.13 removes cgi amongst the "Dead Batteries" declared in PEP 594. webob uses cgi, but it looks like they're not only working to handle it but also might "shim" it for a bugfix release.

I don't have a strong opinion about how webob "should" handle this, so I just look forward to picking up on their new version when it's ready. Our builds are grabbing webob==1.8.8, which is their latest, so I see no reason that we wouldn't be able to use the fix when it's available.

@sirosen
Copy link
Collaborator

sirosen commented Nov 2, 2024

webob shipped new versions; I think we're good to go. Merging!

@sirosen sirosen merged commit d620336 into dev Nov 2, 2024
8 checks passed
@sirosen sirosen deleted the py313 branch November 2, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants