Record invalid type errors per index with many=True #621
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier, errors about invalid types (such as giving primitive for dict) got recorded on
_schema
level for list elements, rather than for each index separately.So for example, first block in the added test used to produce:
With this change it now produces:
I don't know marshmallow internals well, and I am quite unsure this. But if this fix makes sense, we can iterate it into a proper form! :)
I used slightly different style to do asserts. I can replace strings by references to
Field.default_error_messages
, if that's better. Or remove value comparisons altogether. I just think this slightly more verbose form gives reader a better understanding of what is actually inresult.errors
.