Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the error messages for "unknown fields" and "invalid data type" configurable #852

Closed
sloria opened this issue Jun 23, 2018 · 6 comments
Closed

Make the error messages for "unknown fields" and "invalid data type" configurable #852

sloria opened this issue Jun 23, 2018 · 6 comments
Labels
enhancement help wanted
Milestone
3.0

Comments

@sloria
Copy link
Member

sloria commented Jun 23, 2018 •
edited
Loading

As a follow-up to #838 (comment) : Make the error messages for passing unknown fields (currently 'Unknown field.') and invalid input type (currently 'Invalid input type.') configurable on a Schema.
@sloria sloria mentioned this issue Jun 23, 2018
Closed
@sloria sloria mentioned this issue Jul 1, 2018
Merged
@lafrech
Copy link
Member

lafrech commented Jul 1, 2018

Same with "Invalid input type." (#857 (comment)).

@sloria sloria changed the title Make the error message for unknown fields configurable Make the error message for "unknown fields" and "invalid data type" configurable Jul 2, 2018
@sloria
Copy link
Member Author

sloria commented Jul 2, 2018

Good call. Renamed the issue.

@sloria sloria changed the title Make the error message for "unknown fields" and "invalid data type" configurable Make the error messages for "unknown fields" and "invalid data type" configurable Jul 2, 2018
@deckar01 deckar01 mentioned this issue Jul 4, 2018
Merged
@lafrech lafrech mentioned this issue Jul 26, 2018
Closed
@Dunstrom
Copy link
Contributor

Is this issue still relevant? If so I might be able to fix it.

@sloria
Copy link
Member Author

sloria commented Nov 27, 2018

@Dunstrom Yes, this is still up for grabs!

@Dunstrom
Copy link
Contributor

Thanks for the info @sloria, I will start working on this.

@Dunstrom Dunstrom mentioned this issue Dec 5, 2018
Merged
@Dunstrom
Copy link
Contributor

@sloria, I would love it if you had a look at my PR when you get the time!

@lafrech lafrech added this to the 3.0 milestone Dec 16, 2018
deckar01 pushed a commit to deckar01/marshmallow that referenced this issue Jan 8, 2019
Merge branch 'dev' into marshmallow-code#852-configurable-error-messages
f449f31
sloria added a commit that referenced this issue Jan 8, 2019
@sloria
Merge pull request #1067 from Dunstrom/#852-configurable-error-messages
b3bef3c 
#852 configurable error messages
@cristi23 cristi23 mentioned this issue Jul 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
3 participants
@lafrech @sloria @Dunstrom