Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default for unknown to RAISE #851

Closed
sloria opened this issue Jun 23, 2018 · 2 comments · Fixed by #872
Closed

Change default for unknown to RAISE #851

sloria opened this issue Jun 23, 2018 · 2 comments · Fixed by #872
Labels
backwards incompat
Milestone
3.0

Comments

@sloria
Copy link
Member

sloria commented Jun 23, 2018

As a follow up to #524 (comment) and #838 : the default for unknown should be changed to RAISE.
@sloria sloria added this to the 3.0 milestone Jun 23, 2018
@sloria sloria mentioned this issue Jun 23, 2018
Closed
@lafrech lafrech mentioned this issue Jun 27, 2018
Merged
@deckar01 deckar01 mentioned this issue Jul 4, 2018
Merged
@sloria
Copy link
Member Author

sloria commented Jul 5, 2018

@lafrech Were you still planning to work on this?

@lafrech lafrech mentioned this issue Jul 5, 2018
Merged
@lafrech
Copy link
Member

lafrech commented Jul 5, 2018

Yep. I needed #857 merged first.

Here's the PR for this issue: #872.

@sloria sloria removed the help wanted label Jul 5, 2018
cript0nauta added a commit to cript0nauta/faraday that referenced this issue Apr 22, 2019
@cript0nauta
Restore behaviour of marshmallow 2 with unknown keys
a307e8a 
Commit cc17b49534bec5777a7618fc0a64201addbc0c50 of marshmallow broke our
code

See also:

https://marshmallow.readthedocs.io/en/3.0/upgrading.html#schemas-raise-validationerror-when-deserializing-data-with-unknown-keys
marshmallow-code/marshmallow#851
marshmallow-code/marshmallow#872
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backwards incompat
Projects
None yet
Milestone
3.0
Development

Successfully merging a pull request may close this issue.

Change default for unknown to RAISE
2 participants
@lafrech @sloria