Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Pass class attribute to pseudo section on advanced background #48

Merged
merged 3 commits into from
Aug 8, 2018

Conversation

yhatt
Copy link
Member

@yhatt yhatt commented Aug 8, 2018

If you are using Marpit with inline SVG mode (inlineSVG: true), Marpit makes a layer to show section::after pseudo-element for the pagination, that is not affected changing layout by split backgrounds.

When you use paginate directive together with class directive, the created layer has not inherited section's class.

---
paginate: true
class: red
---

<style>
section.red::after {
  color: red;
}
</style>

This page will be colored page number to red in inline SVG mode.

---

![bg left 80%](https://raw.githubusercontent.com/yhatt/marp/master/images/marp.png)

But this page *won't* be colored page number to red in inline SVG mode.

The result of rendering is here (PDF).

This PR will fix this behavior by passing class attribute to <section> on pseudo-layer.

@yhatt yhatt added the bug Something isn't working label Aug 8, 2018
@yhatt yhatt merged commit a6d2bc1 into master Aug 8, 2018
@yhatt yhatt deleted the apply-class-on-pseudo-layer branch August 8, 2018 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant